Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dt estimate for quads/hexes, extend tests for it #338

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@inducer inducer changed the title Enable dt estimate for Quads/Hexes, extend tests for it. Enable dt estimate for Quads/Hexes, extend tests for it Apr 26, 2024
Co-authored-by: Andreas Kloeckner <inform@tiker.net>
@inducer
Copy link
Owner Author

inducer commented Apr 26, 2024

Well... for some very innocuous-looking changes, this has some very exciting-looking failures. 😬

@MTCam
Copy link
Contributor

MTCam commented Apr 26, 2024

Well... for some very innocuous-looking changes, this has some very exciting-looking failures. 😬

I forgot about these. At some point I had worked out a plan for how to fix these tests, but now have turned away too long to remember. I'll have another look.

@inducer inducer changed the title Enable dt estimate for Quads/Hexes, extend tests for it Enable dt estimate for quads/hexes, extend tests for it Apr 29, 2024
@@ -256,11 +271,10 @@ def dt_geometric_factors(
actx = dcoll._setup_actx
volm_discr = dcoll.discr_from_dd(dd)

r_fac = dcoll.dim
if any(not isinstance(grp, SimplexElementGroupBase)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check for supported element types instead.

@inducer
Copy link
Owner Author

inducer commented May 1, 2024

@MTCam Now all the remaining failures are numerical in nature, illustrating (I think) that this does not find a valid time step estimate for tensor product elements even for wave.

@MTCam
Copy link
Contributor

MTCam commented May 1, 2024

@MTCam Now all the remaining failures are numerical in nature, illustrating (I think) that this does not find a valid time step estimate for tensor product elements even for wave.

If we adjust the sketchy fudge factor in the wave operator's rk4 estimate to 0.23 for TPE. I think it passes. That fudge factor is dependent on element type.

I think I also added a skip for the dim=1 tests for TPEs as there is no 1D TPE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants