-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dt estimate for quads/hexes, extend tests for it #338
base: main
Are you sure you want to change the base?
Conversation
2f3a604
to
cc6bc8f
Compare
Co-authored-by: Andreas Kloeckner <inform@tiker.net>
cc6bc8f
to
b3eff8b
Compare
Well... for some very innocuous-looking changes, this has some very exciting-looking failures. 😬 |
I forgot about these. At some point I had worked out a plan for how to fix these tests, but now have turned away too long to remember. I'll have another look. |
@@ -256,11 +271,10 @@ def dt_geometric_factors( | |||
actx = dcoll._setup_actx | |||
volm_discr = dcoll.discr_from_dd(dd) | |||
|
|||
r_fac = dcoll.dim | |||
if any(not isinstance(grp, SimplexElementGroupBase) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should check for supported element types instead.
@MTCam Now all the remaining failures are numerical in nature, illustrating (I think) that this does not find a valid time step estimate for tensor product elements even for wave. |
If we adjust the sketchy fudge factor in the wave operator's rk4 estimate to 0.23 for TPE. I think it passes. That fudge factor is dependent on element type. I think I also added a skip for the dim=1 tests for TPEs as there is no 1D TPE. |
cc @MTCam
TensorProductElementGroupBase.bases_1d
meshmode#409