Support coupled volumes #285
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2022
Closed
majosm
force-pushed
the
coupled-volumes
branch
from
f29b4b6
to
3af1ca5
Compare
majosm
force-pushed
the
coupled-volumes
branch
from
92481b5
to
f2adaba
Compare
majosm
force-pushed
the
coupled-volumes
branch
from
f2adaba
to
1a38e2d
Compare
inducer
reviewed
Apr 11, 2023
| @@ -1015,4 +1017,44 @@ def make_discretization_collection( | |||
| # }}} | |||
|
|
|||
|
|
|||
| # {{{ filter_part_boundaries | |||
|
|
|||
| def filter_part_boundaries( | |||
There was a problem hiding this comment.
get_boundary_dofdescs? ("Filter" is possibly confusing with filtering-for-dissipation. And the function name didn't give me a vibe of returning DOFDescs.)
This was referenced Apr 26, 2023
8 tasks
eases setting up boundaries when calling operators on only one volume (i.e., uncoupled)
|
How far away is this from being reviewable? |
|
Just need to add docs and figure out how to avoid duplicating the mesh in the part ID normalization step (to avoid inducer/meshmode#358). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the rest of the changes from the original #236, #239, #243, #246 chain. Depends on #280.
Still missing: