Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/setup-node from 3 to 4 in /actions/publish #76

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 30, 2023

Bumps actions/setup-node from 3 to 4.

Release notes

Sourced from actions/setup-node's releases.

v4.0.0

What's Changed

In scope of this release we changed version of node runtime for action from node16 to node20 and updated dependencies in actions/setup-node#866

Besides, release contains such changes as:

New Contributors

Full Changelog: actions/setup-node@v3...v4.0.0

v3.8.2

What's Changed

Full Changelog: actions/setup-node@v3...v3.8.2

v3.8.1

What's Changed

In scope of this release, the filter was removed within the cache-save step by @​dmitry-shibanov in actions/setup-node#831. It is filtered and checked in the toolkit/cache library.

Full Changelog: actions/setup-node@v3...v3.8.1

v3.8.0

What's Changed

Bug fixes:

Feature implementations:

Documentation changes:

Update dependencies:

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Oct 30, 2023
@kimkim0814
Copy link
Member

actions/setup-nodeとは?

actions/setup-nodeは、GitHub Actionsという自動化プラットフォームで使用されるアクションの1つ

このアクションは下記の機能を提供している。

公式より引用

  • Optionally downloading and caching distribution of the requested Node.js version, and adding it to the PATH
  • Optionally caching npm/yarn/pnpm dependencies
  • Registering problem matchers for error output
  • Configuring authentication for GPR or npm
  • リクエストされたNode.jsバージョンのディストリビューションをオプションでダウンロードし、キャッシュに追加し、PATHに追加します。
  • npm/yarn/pnpmの依存関係をオプションでキャッシュします。
  • エラー出力用の問題マッチャを登録します。
  • GPR(GitHub Package Registry)またはnpmの認証を構成します。

GitHub Actionsとは?

GitHubリポジトリ内でカスタムワークフローを定義し、ビルド、テスト、デプロイなどのタスクを自動化するためのツール

@kimkim0814
Copy link
Member

kimkim0814 commented Nov 15, 2023

actions/setup-node 3から4の変更点

@@ -14,7 +14,7 @@ inputs:
runs:
using: "composite"
steps:
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18.16.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝
actions/setup-node@v4ではデフォルトでnodeのv20が使用されている。
バージョンを指定して、デグレさせた場合不具合が起きる可能性もあるので調査する必要がありそう。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic

steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
  with:
    node-version: 18
- run: npm ci
- run: npm test

Examples:

Major versions: 14, 16, 18

nodeバージョン18はサポートされている。

setup-nodeは指定されたバージョンのNode.jsをインストールするためのアクションだから、
アクションそのもののバージョンが20になってもインストール先としてサポートしていれば良さそう。

ref:https://github.com/actions/setup-node

@kimkim0814 kimkim0814 requested review from a team and tomoasleep and removed request for a team November 15, 2023 09:17
Copy link
Member

@kimkim0814 kimkim0814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@tomoasleep tomoasleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimkim0814 が見てくれた内容で問題なさそう。 LGTM

@tomoasleep tomoasleep merged commit 7c0b113 into main Nov 16, 2023
5 checks passed
@tomoasleep tomoasleep deleted the dependabot/github_actions/actions/publish/actions/setup-node-4 branch November 16, 2023 02:25
@acronhub acronhub mentioned this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
2 participants