Populate correct initial capacity for List/Set/Map/ImmutableList.Builder #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Uses the `new ArrayList(int)` constructor when `size` is available * Fixes the initial capacity calculation considering the default load factor of `.75` for sets + maps * Uses `ImmutableList.builderWithExpectedSize` where appropriate This change avoids a bunch of "resize" operations and some unnecessary object allocations / heap pressure.
|
Thank you for the PR! it looks good, I just need another detailed look before merge |
|
@elucash You ok with the PR. |
|
Thank you for remainder. I did have another look and it ok, merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new ArrayList(int)constructor whensizeis available.75for sets + mapsImmutableList.builderWithExpectedSizewhere appropriateThis change avoids a bunch of "resize" operations and some unnecessary object allocations / heap pressure.