detect the Eclipse compiler without using the TCCL #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fully agree. If this really works than we should merge it :) |
|
I'll merge it and will try to see if still works in Eclipse. Hope someone will re-validate it works for the language server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1451.
The current implementation depends on the thread context class loader being set to
org.eclipse.osgi.internal.framework.ContextFinderwhich is true in Eclipse IDE, but not in the JDT Language Server used by Visual Studio Code.In addition, it seems that the
EclipseCompilerOrderingProvideris no longer required. It can be disabled by defining the system property-Dorg.immutables.disableEclipseOrderingProvider=truein the VS code settingjava.jdt.ls.vmargs.(The system property and the
EclipseCompilerOrderingProvidershould both be removed if this is confirmed.)Moreover,
java.jdt.ls.vmargsshould include-DmaxCompiledUnitsAtOnce=10000for large projects (see #1450).