Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded the Axios verison #206

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

Nikhil-Ashoka
Copy link
Collaborator

- Upgraded the axios version from 0.21.4 to 1.6.0
- Defect: https://jazz07.rchland.ibm.com:13443/jazz/web/projects/CSSD#action=com.ibm.team.workitem.viewWorkItem&id=603937

Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
@gtmills
Copy link

gtmills commented Mar 21, 2024

How did you test?
Can you push this upsteam?

Copy link

@joseph-reynolds joseph-reynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The axois changes look good. I am approving those. But there are also changes to other packages removed, added, and new checksums. Are these intended?

@Nikhil-Ashoka
Copy link
Collaborator Author

Nikhil-Ashoka commented Mar 21, 2024

How did you test? Can you push this upsteam?

Hey Gunnar, Not sure how to test it, Any suggestions, Looked into this axios/axios#6022 (comment). Seems that this issue would be solved.
Yes, I will also, create a commit for upstream.

@Nikhil-Ashoka
Copy link
Collaborator Author

The axois changes look good. I am approving those. But there are also changes to other packages removed, added, and new checksums. Are these intended?

Yes, The only packages that is updated will be in package.json file.

package-lock.json is automatically generated for any operations where npm modifies either the node_modules tree, or package.json. These are intended.

@rfrandse rfrandse merged commit 6a64994 into ibm-openbmc:1060 Mar 25, 2024
rfrandse pushed a commit that referenced this pull request Mar 25, 2024
- Upgraded the axios version from 0.21.4 to 1.6.0
- Defect: https://jazz07.rchland.ibm.com:13443/jazz/web/projects/CSSD#action=com.ibm.team.workitem.viewWorkItem&id=603937

Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
rfrandse pushed a commit that referenced this pull request Mar 25, 2024
- Upgraded the axios version from 0.21.4 to 1.6.0
- Defect: https://jazz07.rchland.ibm.com:13443/jazz/web/projects/CSSD#action=com.ibm.team.workitem.viewWorkItem&id=603937

Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
rfrandse pushed a commit that referenced this pull request Mar 25, 2024
- Upgraded the axios version from 0.21.4 to 1.6.0
- Defect: https://jazz07.rchland.ibm.com:13443/jazz/web/projects/CSSD#action=com.ibm.team.workitem.viewWorkItem&id=603937

Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants