build: format code with ruff format over black
#7447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepyaman
commented
Oct 26, 2023
deepyaman
commented
Oct 26, 2023
deepyaman
commented
Oct 27, 2023
deepyaman
commented
Oct 27, 2023
deepyaman
commented
Oct 27, 2023
deepyaman
commented
Oct 27, 2023
deepyaman
commented
Oct 27, 2023
deepyaman
commented
Oct 27, 2023
deepyaman
commented
Oct 27, 2023
deepyaman
commented
Oct 27, 2023
deepyaman
commented
Oct 27, 2023
deepyaman
changed the title
ruff formatruff format over black
deepyaman
force-pushed
the
build/ruff-format
branch
from
2809c6d
to
2ddeadc
Compare
deepyaman
force-pushed
the
build/ruff-format
branch
2 times, most recently
from
2d600b0
to
63152f4
Compare
cpcloud
approved these changes
Oct 29, 2023
deepyaman
force-pushed
the
build/ruff-format
branch
4 times, most recently
from
909ebe3
to
3fa18b6
Compare
cpcloud
approved these changes
Oct 31, 2023
deepyaman
force-pushed
the
build/ruff-format
branch
from
82629af
to
bc4efd4
Compare
Great! Went ahead and rebased on top of latest. |
deepyaman
force-pushed
the
build/ruff-format
branch
from
bc4efd4
to
3a73afb
Compare
deepyaman
commented
Nov 1, 2023
deepyaman
force-pushed
the
build/ruff-format
branch
from
11e8969
to
438ad43
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff's Python formatter was announced a couple days ago, so why not? We already use Ruff for linting.
I've commented on the changes Ruff made, but they almost all seem positive (except for the lambda formatting, which is a known issue and already has somebody working on it).
Technically, caught a minor CI issue where the "decompiler" extra wasn't getting installed for tests of that functionality. It worked previously because Black was already a dev dependency.
(I intentionally haven't tried replacing the decompiler functionality with
ruff format. Not sure if I should? Wanted to check first, since I've never even used the decompile functionality myself.)