Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support float32 vector arrays in DQL query variables #781

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

johnymontana
Copy link
Member

@johnymontana johnymontana commented Mar 12, 2025

Description

Updated the Dgraph client APIs to support vector arrays (f32[] in AssemblyScript, []float32 in Go) as parameters to DQL queries.

Checklist

All PRs should check the following boxes:

  • I have given this PR a title using the
    Conventional Commits syntax, leading with fix:,
    feat:, chore:, ci:, etc.
    • The title should also be used for the commit message when the PR is squashed and merged.
  • I have formatted and linted my code with Trunk, per the instructions in
    the contributing guide.

If the PR includes a code change, then also check the following boxes. (If not, then delete the
next section.)

  • I have added an entry to the CHANGELOG.md file.
    • Add to the "UNRELEASED" section at the top of the file, creating one if it doesn't yet exist.
    • Be sure to include the link to this PR, and please sort the section numerically by PR number.
  • I have manually tested the new or modified code, and it appears to behave correctly.
  • I have added or updated unit tests where appropriate, if applicable.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@johnymontana johnymontana requested a review from a team as a code owner March 12, 2025 01:11

Verified

This commit was signed with the committer’s verified signature.
mattjohnsonpint Matt Johnson-Pint

Verified

This commit was signed with the committer’s verified signature.
mattjohnsonpint Matt Johnson-Pint
@mattjohnsonpint mattjohnsonpint changed the title fix: Handle array DQL variables fix: support float32 vector arrays in DQL query variables Mar 12, 2025
@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) March 12, 2025 03:45
@mattjohnsonpint mattjohnsonpint merged commit 959d8b2 into main Mar 12, 2025
101 checks passed
@mattjohnsonpint mattjohnsonpint deleted the array-DQL-variables branch March 12, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants