Fix the chaincode builds #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Kneubuhl <jkneubuh@us.ibm.com>
jkneubuh
force-pushed
the
rel-2.5/feature/testbuild
branch
from
d9e99d3
to
f683912
Compare
mbwhite
approved these changes
Jan 10, 2023
jkneubuh
added a commit
to jkneubuh/fabric-chaincode-node
that referenced
this pull request
Jan 11, 2023
Signed-off-by: Josh Kneubuhl <jkneubuh@us.ibm.com>
mbwhite
added a commit
that referenced
this pull request
Jan 12, 2023
* Pin fabric-shim's dependency on grpc-js to 1.8.1 (#369) Signed-off-by: Josh Kneubuhl <jkneubuh@us.ibm.com> * Publish multi-arch, arm64 docker image Signed-off-by: Josh Kneubuhl <jkneubuh@us.ibm.com> * Update to use arrow functions - removed possible issue with stream referring to the correct value, due to difference in scoping between function() and ()=>{} - ensured that in server mode, the promise was awaited for - fixed the register message being sent as the wrong type Signed-off-by: Matthew B White <whitemat@uk.ibm.com> Signed-off-by: Josh Kneubuhl <jkneubuh@us.ibm.com> Signed-off-by: Matthew B White <whitemat@uk.ibm.com> Co-authored-by: Matthew B White <whitemat@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a regression introduced in grpc-js:1.8.2, pinning the dependency to 1.8.1.
Previously the fabric-shim had a loose dependency on
^1.4.1, which caused errors when the grpc-js runtime was updated with this PRSigned-off-by: Josh Kneubuhl jkneubuh@us.ibm.com