New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker goss test #6955
Fix docker goss test #6955
Conversation
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Explicit port mappings doesn't fix the issue |
Since docker 26.0.0, IPv6 is used by default but our goss_wait test is expecting ports to be exposed on IPv4. Disabling IPv6 should work for all docker versions Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Seems to be introduced by this docker 26.0.0 feature... https://docs.docker.com/engine/release-notes/26.0/#bug-fixes-and-enhancements-1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a sensible approach until all the runners can be updated
@jframe spoke to Josh - this is the preferred approach. Most users should remain on ipv4 |
Disable IPv6 in docker container for goss_wait test Since docker 26.0.0, IPv6 is used by default but our goss_wait test is expecting ports to be exposed on IPv4. Disabling IPv6 should work for all docker versions --------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Usman Saleem <usman@usmans.info>
Disable IPv6 in docker container for goss_wait test Since docker 26.0.0, IPv6 is used by default but our goss_wait test is expecting ports to be exposed on IPv4. Disabling IPv6 should work for all docker versions --------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Usman Saleem <usman@usmans.info>
Fixes docker.yml github workflow on self-hosted runner version 2.315.0 (docker
25.0.4+26.0.0?)Since docker 26.0.0, IPv6 is used by default but our goss_wait test is expecting ports to be exposed on IPv4.
Note, this is a problem for amd64 as well as arm64.
Disabling IPv6 should work for all docker versions, at least while the runners are on various versions of docker.
Once all runners are on 26+ then we could probably change goss_wait.yml to:
and reenable IPv6
Fixes #6929