-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Connection traits to return futures #155
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade quinn
@seanmonstar @eagr what do you think? |
Polling data from the control stream when accepting a new request like before didn\´t work well with the async methods. So I separated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i experimented a bit with quinn 0.9 from #145 and GATs in the Quic
Connection
trait.I changed the trait and implemented it for quinn. And i refactored the h3 implementation to use the new trait.
Of curse this is not finished yet. There are still some failing tests, I removed some code parts that need some refactoring and documentation is missing. But the examples mostly work.
The disadvantages of this:
Advantages:
Open Questions:
I wanted to ask for your opinion before I continue to work in this. Is this the direction this project should go?