Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic in pop_frame() #657

Merged
merged 1 commit into from Feb 13, 2023
Merged

Commits on Feb 13, 2023

  1. fix: panic in pop_frame()

        We met the panic in our production environment, so handle this panic
        condition before panic. The stack backtrace:
    
           0: rust_begin_unwind
                     at
        /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/std/src/panicking.rs:517:5
           1: core::panicking::panic_fmt
                     at
        /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/core/src/panicking.rs:101:14
           2: core::panicking::panic
                     at
        /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/core/src/panicking.rs:50:5
           3: h2::proto::streams::flow_control::FlowControl::send_data
                     at
        /build/vendor/h2/src/proto/streams/flow_control.rs:176:9
           4: h2::proto::streams::prioritize::Prioritize::pop_frame::{{closure}}
                     at
        /build/vendor/h2/src/proto/streams/prioritize.rs:737:33
           5: tracing::span::Span::in_scope
                     at /build/vendor/tracing/src/span.rs:982:9
           6: h2::proto::streams::prioritize::Prioritize::pop_frame
                     at
        /build/vendor/h2/src/proto/streams/prioritize.rs:736:29
           7: h2::proto::streams::prioritize::Prioritize::poll_complete
                     at
        /build/vendor/h2/src/proto/streams/prioritize.rs:497:19
           8: h2::proto::streams::send::Send::poll_complete
                     at /build/vendor/h2/src/proto/streams/send.rs:297:9
           9: h2::proto::streams::streams::Inner::poll_complete
                     at /build/vendor/h2/src/proto/streams/streams.rs:850:16
          10: h2::proto::streams::streams::Streams<B,P>::poll_complete
                     at /build/vendor/h2/src/proto/streams/streams.rs:180:9
          11: h2::proto::connection::Connection<T,P,B>::poll
                     at /build/vendor/h2/src/proto/connection.rs:253:36
          12: <h2::client::Connection<T,B> as
        core::future::future::Future>::poll
          13: ...
    winters.zc committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    fc63ae9 View commit details
    Browse the repository at this point in the history