Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue#648: drop frame if stream is released #651

Merged
merged 1 commit into from Dec 2, 2022
Merged

fix issue#648: drop frame if stream is released #651

merged 1 commit into from Dec 2, 2022

Conversation

silence-coding
Copy link
Contributor

@silence-coding silence-coding commented Dec 1, 2022 •
edited

fix #648

@silence-coding
Copy link
Contributor Author

@seanmonstar Please!

@seanmonstar
Copy link
Member

Code looks good, letting CI run. I guess there isn't really a unit test we can do, huh? Since it's mostly just about reducing memory usage...

@silence-coding
Copy link
Contributor Author

silence-coding commented Dec 2, 2022 •
edited

Code looks good, letting CI run. I guess there isn't really a unit test we can do, huh? Since it's mostly just about reducing memory usage...

Yes, mainly to reduce memory. Who needs to review this code to merge?? @seanmonstar

@seanmonstar seanmonstar merged commit af47a08 into hyperium:master Dec 2, 2022
@maxbear1988
Copy link

@seanmonstar cloud you release a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does the memory have residual memory?
3 participants
@silence-coding @seanmonstar @maxbear1988