Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: whether to trigger this.resize when window resize #490

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

fakership
Copy link
Contributor

No description provided.

@fakership
Copy link
Contributor Author

echarts will not resize when window resize, so i think the resize shoud not as a default behavoir

1 similar comment
@fakership
Copy link
Contributor Author

echarts will not resize when window resize, so i think the resize shoud not as a default behavoir

@fakership
Copy link
Contributor Author

as a config is ok

1 similar comment
@fakership
Copy link
Contributor Author

as a config is ok

@albcunha
Copy link

I came looking for something like this, as when I use react-to-print, echart wont resize.

@hustcc
Copy link
Owner

hustcc commented Aug 24, 2022

rename the config to autoResize, and default value is true.

@fakership
Copy link
Contributor Author

fakership commented Aug 26, 2022

rename the config to autoResize, and default value is true.
@hustcc

done,i have changed triggerReisize to autoResize

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.97% when pulling 677a864 on fakership:master into 0e98914 on hustcc:master.

@hustcc hustcc merged commit a35220e into hustcc:master Sep 1, 2022
@nickpresta
Copy link

@hustcc Any chance you can publish this release? It looks like this option isn't available in version 3.0.2.

Thank you!

@c3-edwinlo
Copy link

@hustcc +1 to the previous comment, would appreciate if this option was published to release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants