Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make onig crate non-optional #1533

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nathaniel-daniel
Copy link
Contributor

@nathaniel-daniel nathaniel-daniel commented May 18, 2024

This PR allows the Rust crate to be used without default features.

I ran into trouble trying to add this crate to a project without its default features. Looks like the onig crate has become a non-optional dependency of this crate as this crate will not compile without it. To reflect this, I made onig a required dependency and added a placeholder feature for backwards compatibility.

If adding multiple regex backends like #1510 is desired, this PR should be reworked to detect multiple enabled regex backends and no enabled regex backends and throw a compile error.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Actually we'd rather leave the optional dependency and fix the compilation issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants