Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mkdirp dependency #165

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

MasterOdin
Copy link
Contributor

@MasterOdin MasterOdin commented Mar 11, 2025

Closes #163

PR removes the mkdirp dependency relying on { recursive: true } for fs.mkdir which has the same behavior. This necessitated bumping the supported node version to 10.12 as that's the version of Node that added this feature.

Note, I did not remove the recursive folder removal in the socket test (https://github.com/node-portfinder/node-portfinder/blob/b64ab4f707fccc079da3f86716ec0c78be61a30b/test/port-finder-socket.test.js#L68-L76) as recursive was added to fs.rmdir in 12.10, and then they deprecated that option and added the fs.rm function in 14.14.

Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
@eriktrom
Copy link
Member

Awesome, thanks!

@eriktrom eriktrom merged commit d551821 into http-party:master Mar 11, 2025
19 checks passed
@eriktrom
Copy link
Member

Note, I did not remove the recursive folder removal in the socket test (https://github.com/node-portfinder/node-portfinder/blob/b64ab4f707fccc079da3f86716ec0c78be61a30b/test/port-finder-socket.test.js#L68-L76) as recursive was added to fs.rmdir in 12.10, and then they deprecated that option and added the fs.rm function in 14.14.

Thanks for being so careful 👍

@MasterOdin MasterOdin deleted the chore-mkdirp branch March 11, 2025 20:49
@MasterOdin MasterOdin mentioned this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mkdirp, upgrade node to >=10.12.0, use built-in node mkdirp
2 participants