Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163
PR removes the
mkdirp
dependency relying on{ recursive: true }
forfs.mkdir
which has the same behavior. This necessitated bumping the supported node version to 10.12 as that's the version of Node that added this feature.Note, I did not remove the recursive folder removal in the socket test (https://github.com/node-portfinder/node-portfinder/blob/b64ab4f707fccc079da3f86716ec0c78be61a30b/test/port-finder-socket.test.js#L68-L76) as
recursive
was added tofs.rmdir
in 12.10, and then they deprecated that option and added thefs.rm
function in 14.14.