Include broadcastable assertions automatically in ActiveSupport::TestCase

[swanson]

There is a note in the Campfire codebase test_helper:

And I noticed I had the same patch in my own codebase:

In #466 it explicitly mentioned the Broadcastable::TestHelpers are "not automatically included" -- but I'm not sure why. @seanpdoyle any insights?

[swanson]

I could also see Turbo::TestAssertions including Turbo::Broadcastable::TestHelpers as well so we just include one module in the railtie if that would be preferable.

[seanpdoyle]

I don't remember specifically, but in retrospect, I think the transitive ActionCable::TestHelper made me hesitant.

Since that isn't included globally, it seemed appropriate to follow suit with these helpers too.

[afcapel]

Thanks @swanson

I think we can include this change as part of a minor release, as it won't cause any harm to people that were already including the module themselves.

module Greetings
  def greet
    "Hello!"
  end
end

class Person
  include Greetings
  include Greetings # Including the module a second time
end

person = Person.new
puts person.greet # Outputs: "Hello!"

[edariedl]

@swanson @afcapel Hi, we are using turbo-rails gem in our Rails app but we are not using the actioncable.

With Rails 7.1 upgrade we had to start to including ActionCable into the app, because turbo-rails failed during initialization without it in production environment. Change in this PR is now causing the following error in our tests probably because of a missing configuration (because we don't need one for our app).

Error:
InvoicePaymentTest#test_pay_foreign_invoice:
NoMethodError: undefined method `fetch' for nil
    /Users/edadriedl/.rbenv/versions/3.3.0-rc1/lib/ruby/gems/3.3.0+0/gems/actioncable-7.1.3/lib/action_cable/server/configuration.rb:38:in `pubsub_adapter'
    /Users/edadriedl/.rbenv/versions/3.3.0-rc1/lib/ruby/gems/3.3.0+0/gems/actioncable-7.1.3/lib/action_cable/server/base.rb:86:in `block in pubsub'
    /Users/edadriedl/.rbenv/versions/3.3.0-rc1/lib/ruby/gems/3.3.0+0/gems/actioncable-7.1.3/lib/action_cable/server/base.rb:86:in `synchronize'
    /Users/edadriedl/.rbenv/versions/3.3.0-rc1/lib/ruby/gems/3.3.0+0/gems/actioncable-7.1.3/lib/action_cable/server/base.rb:86:in `pubsub'
    /Users/edadriedl/.rbenv/versions/3.3.0-rc1/lib/ruby/gems/3.3.0+0/gems/actioncable-7.1.3/lib/action_cable/test_helper.rb:10:in `before_setup'
    /Users/edadriedl/.rbenv/versions/3.3.0-rc1/lib/ruby/gems/3.3.0+0/gems/activerecord-7.1.3/lib/active_record/test_fixtures.rb:11:in `before_setup'
    /Users/edadriedl/.rbenv/versions/3.3.0-rc1/lib/ruby/gems/3.3.0+0/gems/activesupport-7.1.3/lib/active_support/testing/setup_and_teardown.rb:40:in `before_setup'

Is there a way to fix it without adding the complete infratructure for action cable into our app? Thank you.