Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react scripts #5908

Closed
wants to merge 8 commits into from
Closed

Update react scripts #5908

wants to merge 8 commits into from

Commits on Feb 20, 2024

  1. Use CRACO to workaround CRA #11770 

    Signed-off-by: Taylor Smock <tsmock@meta.com>
    @tsmock
    tsmock committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    32c5d25 View commit details
    Browse the repository at this point in the history

  2. Revise implementation to insert testimonial image

    @HelNershingThapa @tsmock
    HelNershingThapa authored and tsmock committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    14a0ddb View commit details
    Browse the repository at this point in the history

  3. Wrap methods which affect UI by act in tests 

    * timers (such as advanceTimersByTime)
* clicks

Signed-off-by: Taylor Smock <tsmock@meta.com>
    @tsmock
    tsmock committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    0431658 View commit details
    Browse the repository at this point in the history

  4. Use Jest 29 instead of Jest 27 

    Signed-off-by: Taylor Smock <tsmock@meta.com>
    @tsmock
    tsmock committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    29e8838 View commit details
    Browse the repository at this point in the history

  5. Use the correct act 

    Signed-off-by: Taylor Smock <tsmock@meta.com>
    @tsmock
    tsmock committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    94d6f28 View commit details
    Browse the repository at this point in the history

  6. Fix some issues so that newer versions of jest don't exit with a non-… 

    …zero exit code

See jestjs/jest#10728 for additional details (in
jest 27)

Signed-off-by: Taylor Smock <tsmock@meta.com>
    @tsmock
    tsmock committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    958b992 View commit details
    Browse the repository at this point in the history

  7. Fix imports for CRA update in rapidEditor 

    Signed-off-by: Taylor Smock <tsmock@meta.com>
    @tsmock
    tsmock committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f826990 View commit details
    Browse the repository at this point in the history

  8. Bump node from 16 to 18 

    Signed-off-by: Taylor Smock <tsmock@meta.com>
    @tsmock
    tsmock committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ce942ab View commit details
    Browse the repository at this point in the history