Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zod-openapi): handle nested app base paths in openapi registration #955

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

luxass
Copy link
Contributor

@luxass luxass commented Feb 4, 2025

This fixes #952

The author should do the following, if applicable

  • Add tests
  • Run tests
  • yarn changeset at the top of this repo and push the changeset
  • Follow the contribution guide

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: 19094d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/zod-openapi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@luxass luxass marked this pull request as ready for review February 4, 2025 05:38
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Feb 4, 2025

@luxass

Awesome work! It was a bug and you fixed it. I'll merge and release a new version. Thank you!

@yusukebe yusukebe merged commit 70a564e into honojs:main Feb 4, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
@luxass luxass deleted the zod-openapi-nested-basepath branch February 9, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zod-openapi] Nested App basePath is not used in OpenAPI route registration
2 participants