fix(zod-openapi): return Response if response is not text or JSON
#853
+62
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: sushichan044 <mail@sushichan.live>
🦋 Changeset detectedLatest commit: 3096667 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yusukebe
commented
Nov 28, 2024
| @@ -1779,21 +1779,21 @@ describe('RouteConfigToTypedResponse', () => { | |||
| age: number | |||
| }, | |||
| 200, | |||
| 'json' | 'text' | |||
| 'json' | |||
There was a problem hiding this comment.
Since now the TypedResponse only allows json with application/json, I fixed the test.
| ? ContentType extends `application/${infer Start}json${infer _End}` | ||
| ? Start extends '' | `${string}+` | `vnd.${string}+` | ||
| ? TypedResponse< | ||
| SimplifyDeepArray<Content> extends JSONValue |
There was a problem hiding this comment.
This is following JSONRespondReturn, which is introduced in hono.
|
Hi @sushichan044! What do you think of this PR? |
|
@yusukebe Looks good! |
|
Thanks! I'll merge this. But I like your implementation! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #842
#852 was a great PR to fix #842. However, type errors should not arise for responses other than HTML. Example:
application/xml. So, the problem will be solved if we setResponseto contents other than JSON or Text like the following.TypedResposewithjsonTypedResponsewithtextResponseThis PR will correct whether the returned value should be a
TypedResponseor aResponsebased on the specified content type.