-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(trpc-server): Use honoReq's bodyCache to provide a body function for trpc's req #850
Conversation
🦋 Changeset detectedLatest commit: 7105516 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @Gaubee This is interesting. It looks good. But one thing. Can you run |
Some middleware (in createContext) may need to read the body. If the raw request instance is provided directly, the body will be consumed prematurely, blocking the development of middleware.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you! I'll merge this and release the new version. |
When I apply this version, I get an error.
The error occurs at the following location. It occurs when I call mutate with hono + trpc. |
@Gaubee Can you handle it? |
so you use bunjs? fix pr in #864 |
Yes. I use Bun v1.1.38. |
…eq (honojs#850) Some middleware (in createContext) may need to read the body. If the raw request instance is provided directly, the body will be consumed prematurely, blocking the development of middleware.
Some middleware (in createContext) may need to read the body. If the raw request instance is provided directly, the body will be consumed prematurely, blocking the development of middleware.