Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(request): toLowerCase() is unnecessary for req.header() #3880

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Feb 1, 2025

The arg of get in the Headers object is not case-insensitive. So, the name.toLowerCase() is unnecessary.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Sorry, something went wrong.

Copy link

github-actions bot commented Feb 1, 2025

Bundle size check

main (093d3fd) #3880 (fd3fc7e) +/-
Bundle Size (B) 18,771B 18,757B -14B
Bundle Size (KB) 18.33K 18.32K -0.01K

Compiler Diagnostics

main (093d3fd) #3880 (fd3fc7e) +/-
Files 257 257 0
Lines 115,048 115,048 0
Identifiers 112,929 112,928 -1
Symbols 301,429 301,429 0
Types 213,638 213,638 0
Instantiations 3,090,073 3,090,073 0
Memory used 445,303K 445,165K -138K
I/O read 0.02s 0.02s 0s
I/O write 0s 0s 0s
Parse time 0.67s 0.67s 0s
Bind time 0.28s 0.3s 0.02s
Check time 5.83s 5.73s -0.1s
Emit time 0s 0s 0s
Total time 6.78s 6.7s -0.08s

Reported by octocov

@yusukebe
Copy link
Member Author

yusukebe commented Feb 1, 2025

Hi @EdamAme-x

Can you review this?

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (b2affb8) to head (cb67408).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3880   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files         162      162           
  Lines       10263    10263           
  Branches     2943     2866   -77     
=======================================
  Hits         9317     9317           
  Misses        945      945           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EdamAme-x EdamAme-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Sorry for late)
If you ping me on X, I will notice it right away!

@yusukebe
Copy link
Member Author

yusukebe commented Feb 2, 2025

@EdamAme-x

Thank you! Merging.

@yusukebe yusukebe merged commit 65edaf2 into main Feb 2, 2025
16 checks passed
@yusukebe yusukebe deleted the refactor/arg-of-headers-get-case-not-case-senstive branch February 2, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants