fix(client): shuold not remove tailing slash from top-level URL (#2523)

* fix(client): shuold not remove tailing slash from top-level URL * denoify
honojs · Apr 18, 2024 · ed51b0b · ed51b0b
1 parent acb56b8
commit ed51b0b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/deno_dist/client/utils.ts b/deno_dist/client/utils.ts
@@ -25,6 +25,9 @@ export const replaceUrlProtocol = (urlString: string, protocol: 'ws' | 'http') =
 }
 
 export const removeIndexString = (urlSting: string) => {
+  if (/^https?:\/\/[^\/]+?\/index$/.test(urlSting)) {
+    return urlSting.replace(/\/index$/, '/')
+  }
   return urlSting.replace(/\/index$/, '')
 }
 

diff --git a/src/client/utils.test.ts b/src/client/utils.test.ts
@@ -78,7 +78,7 @@ describe('removeIndexString', () => {
   it('Should remove last `/index` string', () => {
     let url = 'http://localhost/index'
     let newUrl = removeIndexString(url)
-    expect(newUrl).toBe('http://localhost')
+    expect(newUrl).toBe('http://localhost/')
 
     url = '/index'
     newUrl = removeIndexString(url)

diff --git a/src/client/utils.ts b/src/client/utils.ts
@@ -25,6 +25,9 @@ export const replaceUrlProtocol = (urlString: string, protocol: 'ws' | 'http') =
 }
 
 export const removeIndexString = (urlSting: string) => {
+  if (/^https?:\/\/[^\/]+?\/index$/.test(urlSting)) {
+    return urlSting.replace(/\/index$/, '/')
+  }
   return urlSting.replace(/\/index$/, '')
 }