Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update Go OTel SDK #40

Merged
merged 2 commits into from
Jan 11, 2024
Merged

chore(deps): update Go OTel SDK #40

merged 2 commits into from
Jan 11, 2024

Conversation

lizthegrey
Copy link
Member

Which problem is this PR solving?

  • Review found a bug in addOverCapAttrs()

Short description of the changes

@lizthegrey lizthegrey requested a review from a team as a code owner January 11, 2024 00:26
Copy link

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the work you've done in the upstream OTel SDK but I think we should wait for it to merge before we use it here. It may change further or even be rejected and we'd diverge from the SDK.

@lizthegrey
Copy link
Member Author

I like the work you've done in the upstream OTel SDK but I think we should wait for it to merge before we use it here. It may change further or even be rejected and we'd diverge from the SDK.

Unfortunately, this is necessary for my load testing as without the fix I'm unable to generate enough load to saturate refinery.

@MikeGoldsmith
Copy link

MikeGoldsmith commented Jan 11, 2024

How are you conducting the tests? I think building or running the loadgen from this branch should be okay to run tests with the fix, it just means merging main back into this branch to make sure it has everything.

I'm only reluctant because until it merges, we'll need to open new PRs for each subsequent commit and we all know some PRs can take some tweaking and lobbying to get merged in OTel.

@lizthegrey
Copy link
Member Author

lizthegrey commented Jan 11, 2024

How are you conducting the tests? I think building or running the loadgen from this branch should be okay to run tests with the fix, it just means merging main back into this branch to make sure it has everything.

I'm only reluctant because until it merges, we'll need to open new PRs for each subsequent commit and we all know some PRs can take some tweaking and lobbying to get merged in OTel.

A maintainer has taken responsibility for it to the point of filing an issue for go1.20 cleanup after it is merged :) should get merged in the next day or so, and in the meanwhile this is not a public repo, and is in use nowhere else in Honeycomb yet besides my test.

open-telemetry/opentelemetry-go#4819

Copy link

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with @lizthegrey and seeing the upstream PR starting to get approvals, we agreed it's okay to merge this PR now and then fix it up once the next otel-go SDK is released.

@lizthegrey
Copy link
Member Author

Used a cherry-pick on top of v1.21.0 in case there are any problems lurking in otel-go at main.

@lizthegrey lizthegrey merged commit 7c7e824 into main Jan 11, 2024
2 checks passed
@lizthegrey lizthegrey deleted the lizf.update-sdk branch January 11, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants