Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black caching [ci] #99967

Merged
merged 3 commits into from Sep 9, 2023
Merged

Add black caching [ci] #99967

merged 3 commits into from Sep 9, 2023

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Sep 9, 2023

Proposed change

This PR adds CI caching for black similar to mypy. It improves the time for a full black run from ~4:30min (~2:30min with mypyc compiled version of black) to <20s for successive runs.

Requires

For details

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels Sep 9, 2023
@cdce8p cdce8p marked this pull request as draft September 9, 2023 06:52
@cdce8p cdce8p mentioned this pull request Sep 9, 2023
20 tasks
@bdraco
Copy link
Member

bdraco commented Sep 9, 2023

Very nice!

@cdce8p cdce8p marked this pull request as ready for review September 9, 2023 13:32
@bdraco bdraco merged commit c77eb70 into home-assistant:dev Sep 9, 2023
34 checks passed
@cdce8p cdce8p deleted the ci-black-cache branch September 9, 2023 13:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants