Replace bandit with ruff #93200
Merged
Replace bandit with ruff #93200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
core
has-tests
integration: command_line
integration: gtfs
integration: influxdb
integration: recorder
integration: yi
small-pr
|
Hey there @mdegat01, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @bachya, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
scop
changed the title
Only one trivial docstring thing to address. `keep-runtime-typing` replaced by `UP006` and `UP007` ignores: https://github.com/astral-sh/ruff/blob/main/BREAKING_CHANGES.md#00268
B325 is not available in ruff, but it has been removed in bandit, too.
frenck
approved these changes
Jun 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Move from bandit to ruff. Ruff >= 0.0.271 will be needed before this can go in.
Remaining rules:
flake8-bandit] Implementparamiko-call(S601) astral-sh/ruff#4500, in ruff >= 0.0.270The following discussion applies to an earlier submission where I proposed a partial move to ruff, with some rules still missing it. Keeping it for historical purposes.
Even though not all rules are yet available in ruff, I suppose consolidating towards it is a good thing. It appears to be doing a better job than bandit for at least some rules; it does not support
nosec, and migrating them to supportednoqas turned up no things that could be removed. It did flag some additional, valid ones that were missed by bandit.Removal of these bandit rules brings the time it takes to run it down a bit, too. With B601 and B609 still left there but others removed, the times I see for
time pre-commit run bandit --all-filesgo down from about...to roughly
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: