Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pysuezV2 to 2.0.4 #139824

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Bump pysuezV2 to 2.0.4 #139824

merged 1 commit into from
Mar 5, 2025

Conversation

jb101010-2
Copy link
Contributor

Breaking change

Extra states attributes of yesterday sensor have changed.
Historical data is now available only for the last 2 years, and is now formatted like year-month (2025-01).

Proposed change

Bump pysuezV2 to 2.0.4. jb101010-2/pySuez@2.0.3...2.0.4
This changes fixes the integration which did not work because Suez dropped their old API.

Unfortunately the old API provided more data which are not easily available with the new one, this concerns mostly historical and aggregated data.
These changes are adressed by #131166 which fetches everything as statistics.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Sorry, something went wrong.

@home-assistant
Copy link

home-assistant bot commented Mar 5, 2025

Hey there @ooii, mind taking a look at this pull request as it has been labeled with an integration (suez_water) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of suez_water can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign suez_water Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@abmantis abmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you detail a bit more the breaking change, on the PR description, to explain the change to last_year_overall and this_year_overrall?

@home-assistant home-assistant bot marked this pull request as draft March 5, 2025 16:54
@home-assistant
Copy link

home-assistant bot commented Mar 5, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jb101010-2
Copy link
Contributor Author

jb101010-2 commented Mar 5, 2025

Can you detail a bit more the breaking change, on the PR description, to explain the change to last_year_overall and this_year_overrall?

No real change on that part, I just fixed an invalid type in the lib but the data remained the same.
Because I had to manually build data I faced this mistake.

Complete typing and checks are a work in progress in the lib.

@jb101010-2 jb101010-2 marked this pull request as ready for review March 5, 2025 17:04
@home-assistant home-assistant bot requested a review from abmantis March 5, 2025 17:04
@abmantis
Copy link
Contributor

abmantis commented Mar 5, 2025

Thanks @jb101010-2 !

@abmantis abmantis merged commit b225a7f into home-assistant:dev Mar 5, 2025
46 of 47 checks passed
@jb101010-2 jb101010-2 deleted the fix_suez-api branch March 5, 2025 17:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2025
@abmantis abmantis added this to the 2025.3.3 milestone Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suez Water] Issue Suez data update failed
3 participants