Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of old firmware versions #125406

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

tl-sl
Copy link
Contributor

@tl-sl tl-sl commented Sep 6, 2024

Breaking change

Proposed change

SLZB-06 core (esp32) firmware introduced the API required for this integration in v2.3.6. If a user has an older version of the firmware than this, we can still get enough information from the device to setup device registry and create a repair advising to upgrade.

This PR will allow users to install the integration on unsupported firmware (currently this is crashing) and then a repair will be created advising to update.

  • Users on v0.9.9 core firmware will need to visit the SMLIGHT web flasher to update via USB (webpage linked by the learn more button).
  • Users on v2.x < v2.3.6 core firmware can upgrade from the SLZB-06 device SMLIGHT web UI, but eventually will be able to update from HA with the update entities to be introduced in a later PR

Perhaps this could also be applied to the stable branch, however it does also require dependency update per:
#125387

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Sorry, something went wrong.

@thecode
Copy link
Member

thecode commented Sep 6, 2024

@tl-sl I have tagged both PRs (this and #125387) for the next milestone

@tl-sl
Copy link
Contributor Author

tl-sl commented Sep 6, 2024

thanks @thecode

@balloob balloob merged commit 6b1fc00 into home-assistant:dev Sep 6, 2024
28 checks passed
balloob pushed a commit that referenced this pull request Sep 6, 2024
* Update Info fixture with new fields from pysmlight 0.0.14

* Create repair if device is running unsupported firmware

* Add test for legacy firmware info

* Add strings for repair issue
@balloob balloob mentioned this pull request Sep 6, 2024
@tl-sl tl-sl deleted the legacy-api-PR branch September 6, 2024 23:48
Gigatrappeur pushed a commit to Gigatrappeur/ha-core that referenced this pull request Sep 7, 2024
* Update Info fixture with new fields from pysmlight 0.0.14

* Create repair if device is running unsupported firmware

* Add test for legacy firmware info

* Add strings for repair issue
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2024
@tl-sl tl-sl restored the legacy-api-PR branch September 17, 2024 09:52
@tl-sl tl-sl deleted the legacy-api-PR branch September 23, 2024 00:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when setting up new SMLIGHT integration
3 participants