Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tplink bug changing color temp on bulbs with light effects #121696

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

sdb9696
Copy link
Contributor

@sdb9696 sdb9696 commented Jul 10, 2024

Proposed change

Fixes an issue with "L530E Series" devices when setting color temp on the device. The device errors and needs to be power cycled after this error.

Partially fixes #121362, a separate library bump PR is required to fully fix but this will fix any other models affected in a similar way.

EDIT: I've tested with L530E, L910 and KL430.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @rytilahti, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@sdb9696 sdb9696 changed the title Tplink fix issues with older device hardware modesl Tplink fix issues with older tapo device hardware models Jul 10, 2024
@sdb9696 sdb9696 changed the title Tplink fix issues with older tapo device hardware models Fix tplink bug changing color temp on bulbs with light effects Jul 11, 2024
@sdb9696 sdb9696 marked this pull request as ready for review July 11, 2024 14:12
@sdb9696 sdb9696 requested review from rytilahti and bdraco as code owners July 11, 2024 14:12
@rytilahti rytilahti added this to the 2024.7.3 milestone Jul 11, 2024
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I haven't tested this on any devices as I currently have no access to mine (nor do I have this specific model, anyway).

@sdb9696
Copy link
Contributor Author

sdb9696 commented Jul 11, 2024

LGTM, but I haven't tested this on any devices as I currently have no access to mine (nor do I have this specific model, anyway).

I've tested with L530E, L910 and KL430.

@bdraco
Copy link
Member

bdraco commented Jul 11, 2024

KL430 seems fine

@bdraco
Copy link
Member

bdraco commented Jul 11, 2024

L930 ok as well

@bdraco
Copy link
Member

bdraco commented Jul 11, 2024

L530 👍

@bdraco
Copy link
Member

bdraco commented Jul 11, 2024

I had trouble finding the L530 because the OUI was missing
#121785

@bdraco bdraco mentioned this pull request Jul 11, 2024
19 tasks
@bdraco bdraco merged commit 2148cfc into home-assistant:dev Jul 11, 2024
26 checks passed
@sdb9696 sdb9696 deleted the tplink/fix_timeouts branch July 11, 2024 15:16
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After update 2024.7, Bulbs L530E will unavailable and including in Tapo app
4 participants