Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobuf to 5.26.0 #113380

Closed
wants to merge 2 commits into from
Closed

Bump protobuf to 5.26.0 #113380

wants to merge 2 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 14, 2024

blockers:

Proposed change

changelog: protocolbuffers/protobuf@v25.1...v26.0

There is a memory leak fix for python

There are some breaking changes

[Python] Removed obsolete/duplicate setup.py from Python. (protocolbuffers/protobuf#15708) (protocolbuffers/protobuf@5722aef)
[Python] Made text_format output default to UTF-8. (protocolbuffers/protobuf@bf00034)
[Python] Remove RegisterExtension in message class (protocolbuffers/protobuf@4ebba68)
[Python] Reject extend repeated field with none iterable (Raise TypeError) (protocolbuffers/protobuf@1658213)
[Python] Remove Deprecated APIs that add non top descriptor. (protocolbuffers/protobuf@c51f111)
[Python] Check if Timestamp is valid. (protocolbuffers/protobuf@4f77929)
[Python] Remove msg.UnknownFields() support in pure python and cpp extension. (protocolbuffers/protobuf@0eac77c)
[Python] Remove deprecated syntax accessor. (protocolbuffers/protobuf@fd40c87)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core dependency small-pr PRs with less than 30 lines. labels Mar 14, 2024
changelog: protocolbuffers/protobuf@v25.1...v26.0

There is a memory leak fix for python
@bdraco bdraco changed the title Bump protobuf to 4.26.0 Bump protobuf to 5.26.0 Mar 14, 2024
@tronikos tronikos mentioned this pull request Mar 14, 2024
20 tasks
@bdraco bdraco closed this May 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant