-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023.12.0 #105135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frenck
commented
Dec 6, 2023
•
edited
edited
Co-authored-by: Franck Nijhof <git@frenck.dev>
Co-authored-by: Franck Nijhof <git@frenck.dev>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <git@frenck.dev>
…Care integration (#104371)
…reate) (#89090) * Added scene.delete service Only for scenes created with scene.create * Refactor after #95984 #96390 * Split scene validation in 2 First, check if entity_id is a scene Second, check if it's a scene created with `scene.create` * Address feedback - Move service to `homeassistant` domain - Register with `platform.async_register_entity_service` - Raise validation errors instead of just logging messages * Revert moving the service to the `homeassistant` domain * Remove unneeded validation * Use helpers and fix tests * Apply suggestions from code review Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * Fix linting --------- Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
* Update requirements_all.txt * Update requirements_test_all.txt * Update manifest.json
Bump nibe to 2.5.2
fix translation key
Co-authored-by: Duco Sebel <74970928+DCSBL@users.noreply.github.com>
frenck
requested review from
dgomes,
teharris1,
marcelveldt,
scop,
bramkragten,
davet2001,
cgarwood,
cdce8p,
zxdavb,
OttoWinter,
jesserockz and
ochlocracy
as code owners
December 6, 2023 15:36
home-assistant
bot
added
cla-signed
core
integration: accuweather
integration: adguard
integration: adax
merging-to-master
This PR is merging into the RC branch and should probably change the branch to `dev`.
by-code-owner
labels
Dec 6, 2023
joostlek
approved these changes
Dec 6, 2023
jbouwh
approved these changes
Dec 6, 2023
janiversen
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
jpbede
approved these changes
Dec 6, 2023
Kane610
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉
bieniu
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cla-signed
core
integration: accuweather
integration: adax
integration: adguard
merging-to-master
This PR is merging into the RC branch and should probably change the branch to `dev`.
Quality Scale: No score
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.