Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JPEG filetype from jpg to jpeg. #4904

Merged
merged 1 commit into from May 22, 2023
Merged

Update JPEG filetype from jpg to jpeg. #4904

merged 1 commit into from May 22, 2023

Conversation

n3011
Copy link
Contributor

@n3011 n3011 commented May 20, 2023

Pillow library does not have the _repr_jpg_ method. Recently the _repr_jpeg_ method is added python-pillow/Pillow#7135

Use filetype as jpeg.
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #4904 (c9935db) into main (c85b49b) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4904      +/-   ##
==========================================
- Coverage   83.44%   83.25%   -0.19%     
==========================================
  Files         270      270              
  Lines       38153    38153              
==========================================
- Hits        31835    31764      -71     
- Misses       6318     6389      +71     
Flag Coverage Δ
ui-tests 39.82% <100.00%> (-1.07%) ⬇️
unitexamples-tests 73.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/image.py 87.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member

Thanks _repr_jpeg_ is indeed the canonical form: https://ipython.readthedocs.io/en/stable/config/integrating.html#custom-methods

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Test failures are unrelated.

@philippjfr philippjfr merged commit f8770f3 into holoviz:main May 22, 2023
13 of 15 checks passed
@n3011 n3011 deleted the patch-1 branch May 22, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants