test: add conductor api serialization guard #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveej
requested changes
Nov 21, 2023
ThetaSinner
reviewed
Nov 22, 2023
thedavidmeister
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the Conductor API broke without our knowledge because of a change in a serde patch version from 1.0.180 to 1.0.181. I've added smoke tests to the serialization of App and Admin API in the Holochain repo and want to add a similar test to this repo too.
There's no Cargo lock in this repo and it specifies serde at minimum version 1.0.123. When used in the Holochain repo, serde is effectively above 1.0.181, so that's what I want to set the minimum version to in this repo.
Let me know what you think about the JSON part of the test especially.
I've removed the
nix-shellcommand from the pipeline config as it wasn't needed for running the tests.