Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't re-review when new commits are pushed #214

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Don't re-review when new commits are pushed #214

merged 1 commit into from
Mar 9, 2023

Commits on Mar 8, 2023

  1. Don't re-review when new commits are pushed 

    It is possible to require re-reviews when new commits are pushed via
branch protection rules, but when that setting is enabled existing
reviews are transitioned to `DISMISSED`, so we should already handle
that case with the `state === "APPROVED"` check.
    @hmarr
    hmarr committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    a6bb174 View commit details
    Browse the repository at this point in the history