Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scheme Property to Be Case-Insensitive in securitySchemeObjectToAuthObject Function #1816

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

shemsiu
Copy link

@shemsiu shemsiu commented Mar 13, 2025

This pull request introduces a change to the securitySchemeObjectToAuthObject function to allow the scheme property to be case-insensitive by converting it to lowercase. This ensures that the function can handle schemes provided in any case format (e.g., "Bearer", "bearer", "BEARER").

Copy link

stackblitz bot commented Mar 13, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: b9e1b4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hey-api/openapi-ts Patch
@hey-api/nuxt Patch
@example/openapi-ts-nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 4:52pm

@mrlubos
Copy link
Member

mrlubos commented Mar 13, 2025

@shemsiu can scheme be in uppercase?

@mrlubos
Copy link
Member

mrlubos commented Mar 13, 2025

It can, I see

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.24%. Comparing base (50e7ea7) to head (b9e1b4b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ages/openapi-ts/src/plugins/@hey-api/sdk/plugin.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1816   +/-   ##
=======================================
  Coverage   57.23%   57.24%           
=======================================
  Files         191      191           
  Lines       25892    25890    -2     
  Branches     1958     1958           
=======================================
  Hits        14820    14820           
+ Misses      11063    11061    -2     
  Partials        9        9           
Flag Coverage Δ
unittests 57.24% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

pkg-pr-new bot commented Mar 13, 2025

Open in Stackblitz

@hey-api/client-axios

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-axios@1816

@hey-api/client-fetch

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-fetch@1816

@hey-api/client-next

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-next@1816

@hey-api/client-nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-nuxt@1816

@hey-api/nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@1816

@hey-api/openapi-ts

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@1816

@hey-api/rollup-plugin

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/rollup-plugin@1816

commit: b9e1b4b

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mrlubos
Copy link
Member

mrlubos commented Mar 13, 2025

Good catch, thank you @shemsiu

@mrlubos mrlubos merged commit 2faa3ea into hey-api:main Mar 13, 2025
15 of 16 checks passed
@github-actions github-actions bot mentioned this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants