Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prepare for migration to typescript #5094

Merged
merged 4 commits into from Dec 10, 2022
Merged

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Nov 2, 2022

What does it do?

Convert some requires to top level. They will be the static import after #5092
Some lazyload requires e.g. if (!highlight) highlight = require('hexo-util').highlight; are left untouched.

And, found some possible bugs in #5092
lib/plugins/console/generate.js 9ba40f4
lib/hexo/scaffold.js 3323364

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

@coveralls
Copy link

coveralls commented Nov 2, 2022

Coverage Status

Coverage decreased (-0.03%) to 98.743% when pulling 315ddcd on top-level-import into 807ddd8 on master.

lib/hexo/index.js Outdated Show resolved Hide resolved
lib/plugins/console/index.js Outdated Show resolved Hide resolved
@stevenjoezhang stevenjoezhang marked this pull request as draft November 2, 2022 08:04
@yoshinorin yoshinorin added this to the 7.0.0 milestone Nov 21, 2022
@stevenjoezhang stevenjoezhang changed the title refactor: top-level import refactor: prepare for migration to typescript Nov 24, 2022
@stevenjoezhang stevenjoezhang marked this pull request as ready for review November 24, 2022 17:09
@stevenjoezhang stevenjoezhang mentioned this pull request Nov 24, 2022
6 tasks
@SukkaW SukkaW merged commit 6127df4 into master Dec 10, 2022
@stevenjoezhang stevenjoezhang deleted the top-level-import branch December 10, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants