refactor: drop youtube tag
#5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to testgit clone -b refactor/drop-youtube-tag https://github.com/yoshinorin/hexo.git
cd hexo
npm install
npm test |
This was referenced Sep 17, 2022
|
Maybe we could implement those as a separate plugin, like |
renbaoshuo
approved these changes
Sep 20, 2022
|
refs: #5113 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Breaking Changes
IMHO, an application should not depends on a specific service as possible. Actually, I never use embedded youtube on my blog. These tags should provide as a plugin and should not include any core module.
If we drop this, we have to announce and create a new plugin for current users.
Screenshots
N/A
Pull request tasks