Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require node.js18+, replace eslint-plugin-node and update dependencies #54

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

yoshinorin
Copy link
Member

check list

  • Add test cases for the changes.
  • Passed the CI test.

Changes

Others

I'm going to migrate eslint to 9.x after merge this PR. Thanks :)

Sorry, something went wrong.

@uiolee
Copy link
Member

uiolee commented Jul 6, 2024

it doesn't look right.

$ pnpm eslint

> hexo@7.3.0 eslint D:\hexo
> eslint lib test


Oops! Something went wrong! :(

ESLint: 8.57.0

ESLint couldn't find the plugin "eslint-plugin-node".

(The package "eslint-plugin-node" was not found when loaded as a Node module from the directory "D:\hexo".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install eslint-plugin-node@latest --save-dev

The plugin "eslint-plugin-node" was referenced from the config file in ".eslintrc.json » eslint-config-hexo/ts.js » ./eslint.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

 ELIFECYCLE  Command failed with exit code 2.
================
exit: 2

https://github.com/eslint-community/eslint-plugin-n?tab=readme-ov-file#eslintrcjson-legacy-example

also need to modify the node to n in the configuration files.

extends: ['eslint:recommended', 'plugin:node/recommended'],

@yoshinorin
Copy link
Member Author

also need to modify the node to n in the configuration files.

Thanks. I'll fix later :)

@yoshinorin yoshinorin marked this pull request as draft July 8, 2024 22:50
@yoshinorin yoshinorin marked this pull request as ready for review July 14, 2024 16:24
@yoshinorin
Copy link
Member Author

yoshinorin commented Jul 14, 2024

Thanks. I'll fix later :)

Done. You can try this as follows.

"devDependencies": {
  "eslint": "8.57.0",
  "eslint-config-hexo": "git+https://github.com/hexojs/eslint-config-hexo.git#68f2e9c694f75b2d92ed068d065ae95f20e51ed6",

@yoshinorin yoshinorin merged commit 90c1854 into hexojs:master Jul 17, 2024
@yoshinorin yoshinorin deleted the chore/update-node-and-deps branch July 17, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants