feat(rdns): support setting RDNS for Primary IPs #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously you could only set the RDNS for Primary IPs if they were attached to a server, through the `server_id` attribute. This now also allows setting the RDNS for Primary IPs directly, even if they are not attached to a server. Closes #668
apricote
force-pushed
the
rdns-primary-ip
branch
from
ab953ae to
1a3b5b9
Compare
samcday
reviewed
Apr 28, 2023
samcday
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you could only set the RDNS for Primary IPs if they were attached to a server, through the
server_idattribute. This now also allows setting the RDNS for Primary IPs directly, even if they are not attached to a server.Closes #668