-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tracing
library to generate spans
#918
Merged
Merged
+92
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ooh, I like this more than #917. |
edmorley
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I really like the approach of using the tracing
crate - it seems this will be easier for individual language CNBs to adopt :-)
edmorley
reviewed
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #917 -- personally, I prefer this one. This sets up
tracing
so that it emits trace data into our opentelemetry file exporter pipeline while correctly honoring the cascade of events from kodon, through libcnb, and buildpack specific spans.Using
tracing
for recording span data in CNBs looks like this:tracing
is a widely used library, even within libraries. This seems like the more rust-like approach. #917 by comparison is the moreopentelemetry
-like approach and closer to that standard.As an added bonus the
tracing
library automatically addscode.lineno
,code.filepath
,code.namespace
attributes to spans and events.There are some changes to the shape of the tracing data - some span names, some attributes have changed. Most of this is because we are accepting
tracing-opentelemetry
conventions.