Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ruby 3.2 #203

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Add support for Ruby 3.2 #203

merged 1 commit into from
Mar 13, 2023

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Mar 10, 2023

Currently hatchet ci:setup fails on Ruby 3.2, with:

bundle exec hatchet ci:setup
/home/runner/work/heroku-buildpack-python/heroku-buildpack-python/vendor/bundle/ruby/3.2.0/gems/heroku_hatchet-8.0.2/etc/ci_setup.rb:15:in `<main>': undefined method `exists?' for File:Class (NoMethodError)

unless File.exists?(netrc_file)
           ^^^^^^^^
Did you mean?  exist?

GUS-W-12670528.

Currently `hatchet ci:setup` fails on Ruby 3.2, with:

```
bundle exec hatchet ci:setup
/home/runner/work/heroku-buildpack-python/heroku-buildpack-python/vendor/bundle/ruby/3.2.0/gems/heroku_hatchet-8.0.2/etc/ci_setup.rb:15:in `<main>': undefined method `exists?' for File:Class (NoMethodError)

unless File.exists?(netrc_file)
           ^^^^^^^^
Did you mean?  exist?
```
@edmorley edmorley self-assigned this Mar 10, 2023
@edmorley edmorley marked this pull request as ready for review March 10, 2023 11:20
@edmorley edmorley requested a review from schneems March 10, 2023 11:20
@edmorley edmorley enabled auto-merge (squash) March 13, 2023 12:25
Copy link
Contributor

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@edmorley edmorley merged commit 514bdcb into main Mar 13, 2023
@edmorley edmorley deleted the edmorley/ruby-3.2 branch March 13, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants