Introduce global print functions #21
Merged
+625
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/global-gym
branch
from
11f39c8 to
456fbfe
Compare
This moves the bulk of write formatting out of the Print struct state machine. This opens up the ability to re-use it with a global writer and retain consistent formatting.
Today if an error causes a `Print` struct to be dropped, there's no way to know later if the next line needs to be empty or not. This PR introduces a global writer that tracks the number of newlines previously written to the output. Calling `Print::global` tells the writer to use that prior information when resuming.
Details in the module docs and style guide
schneems
force-pushed
the
schneems/global-gym
branch
from
a960c4c to
c7d8b6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bullet_stream::global::printfunctions for printing without needing to jump through strict type checked stateful hoops. It's less safe, but faster to get up and running.Print::global()which supports resuming printing after an error.