4.1.3: Allow config to set camel (default) or snake case for built-in meter names #9434
+440
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…names (helidon-io#9429) * Allow config to set camel (default) or snake case for built-in meter names Signed-off-by: Tim Quinn <tim.quinn@oracle.com> * Add an MP test for when the SNAKE choice is selected --------- Signed-off-by: Tim Quinn <tim.quinn@oracle.com>
barchetta
added
metrics
backport
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #9429 to Helidon 4.1.3
Description
Resolves #8422
built-in-meter-name-formatwith choicesCAMEL(default)andSNAKE. The JavaDoc (and therefore the generated config documentation) notes that selectingSNAKE` does not conform to the MP Metrics spec; the built-in meter names are specified there.memory.usedHeapormemory.used_heapfor example).REST.request.unmappedException.totalorREST.request.unmapped_exception.total.The sets of names are hard-coded; the new code does not try to convert "camelCase" names automatically to their "snake_case" counterparts.
Documentation
The Javadoc for the new metrics config setting should be a good enough explanation without requiring changes to the doc page itself.