Fix problems with tracing data propagation #8742
Merged
+214
−59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8722
Several problems:
DataPropagationProvider
. As a result, OTel-based tracing information was never propagated via context.TracingObserver
registered only theSpanContext
in the context, not also theSpan
andTracer
. The existing Jaeger data propagation provider and the new one for OTel need to retrieve theSpan
from the context so we can re-establish that span as the active span during arunInContext
.propagateData
method incorrectly used the current span rather than the span captured in theJaegerContext
object earlier. The analogous code in the newOpenTelemetryDataPropagationProvider
uses the saved context instead and the analogous Jaeger type now extends that OTel implementation.Because Jaeger relies on OTel, the Jaeger and the OTel propagation providers are virtually identical. This PR makes the Jaeger one a subclass of the new OTel one to avoid duplicating the code.
Documentation
Bug fix; no doc impact.