Fix plugin reload when in a namespace #5937
Merged
+23
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't looked at the test yet but this looks good! |
jefferai
approved these changes
Dec 11, 2018
calvn
reviewed
Dec 12, 2018
| @@ -2905,6 +2914,9 @@ func (b *SystemBackend) pathInternalUIMountRead(ctx context.Context, req *logica | |||
| Data: mountInfo(me), | |||
| } | |||
| resp.Data["path"] = me.Path | |||
| if ns.ID != me.Namespace().ID { | |||
There was a problem hiding this comment.
Wouldn't MatchingMountEntry always return the mounts for the namespace from the passed in context? In what cases would this check apply?
There was a problem hiding this comment.
This fixes being able to reach into sub-namespaces and access the mount info. So if you wanted to do:
vault kv put ns/kv/foo bar=baz
jefferai
pushed a commit
that referenced
this pull request
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are in a PR on enterprise