Change ordering of user lookup vs. password hashing #5614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a very minor information leak where someone could brute force the existence of a username. It's not perfect as the underlying storage plays a part but bcrypt's slowness puts that much more in the noise.
calvn
reviewed
Oct 25, 2018
calvn
previously approved these changes
Oct 25, 2018
chrishoffman
previously approved these changes
Oct 26, 2018
vishalnayak
previously approved these changes
Oct 26, 2018
jefferai
dismissed stale reviews from vishalnayak, chrishoffman, and calvn
via
e40dd1c
briankassouf
pushed a commit
that referenced
this pull request
Nov 9, 2018
* Change ordering of user lookup vs. password hashing This fixes a very minor information leak where someone could brute force the existence of a username. It's not perfect as the underlying storage plays a part but bcrypt's slowness puts that much more in the noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a very minor information leak where someone could brute force
the existence of a username. It's not perfect as the underlying storage
plays a part but bcrypt's slowness puts that much more in the noise.