Validate OCSP response is signed by expected issuer #26091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevendpclark
commented
Mar 22, 2024
stevendpclark
commented
- There was a bug in the OCSP response signature logic, it properly verified but kept around the ocspRes object around so we ignored the errors found and passed the response object back up the stack.
- Now extract the verification logic into a dedicated function, if it returns an error, blank the ocspRes response as we can't trust it.
- Address an issue that the OCSP requests from multiple servers were clobbering each others responses as the index loop variable was not properly captured.
- Add a missing validation that the response was for the serial number we requested
… matches request
- There was a bug in the OCSP response signature logic, it properly
verified but kept around the ocspRes object around so we ignored
the errors found and passed the response object back up the stack.
- Now extract the verification logic into a dedicated function, if
it returns an error, blank the ocspRes response as we can't trust it.
- Address an issue that the OCSP requests from multiple servers were
clobbering each others responses as the index loop variable was not
properly captured.
- Add a missing validation that the response was for the serial number
we requested
stevendpclark
added
bug
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
sgmiller
approved these changes
Mar 22, 2024
stevendpclark
deleted the
stevendpclark/vault-24879-ocsp-response-validation
branch
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.