Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Fix api/ and sdk/ package tests into release/1.14.x #25071

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Backport of Fix api/ and sdk/ package tests into release/1.14.x #25071

merged 1 commit into from
Jan 25, 2024

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core commented Jan 25, 2024 •
edited by miagilepner

Backport

This PR is auto-generated from #25067 to be assessed for backporting due to the inclusion of the label backport/1.14.x.

The below text is copied from the body of the original PR.

Original PR had no description content.

Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 25, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 25, 2024
@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@miagilepner miagilepner force-pushed the backport/miagilepner/api-sdk-tests/reasonably-live-amoeba branch 2 times, most recently from 220a3be to b9f64f9 Compare January 25, 2024 14:20
@miagilepner miagilepner marked this pull request as ready for review January 25, 2024 16:23
@miagilepner miagilepner requested a review from a team as a code owner January 25, 2024 16:23
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

stevendpclark
stevendpclark approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@miagilepner
backport of commit 49a59bd (#25067)
384e57f 
* fix

* left in incorrectly

* don't print generate commands

* handle line breaks

* remove -e
@miagilepner miagilepner force-pushed the backport/miagilepner/api-sdk-tests/reasonably-live-amoeba branch from b9f64f9 to 384e57f Compare January 25, 2024 17:43
@miagilepner miagilepner enabled auto-merge (squash) January 25, 2024 17:44
@miagilepner miagilepner merged commit 6403cfc into release/1.14.x Jan 25, 2024
99 checks passed
@miagilepner miagilepner deleted the backport/miagilepner/api-sdk-tests/reasonably-live-amoeba branch January 25, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendpclark stevendpclark stevendpclark approved these changes

@tomhjp tomhjp tomhjp left review comments

@miagilepner miagilepner Awaiting requested review from miagilepner

@raskchanky raskchanky Awaiting requested review from raskchanky

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hc-github-team-secure-vault-core @hashicorp-cla @stevendpclark @tomhjp @miagilepner