Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAULT-22270] API: add enterprise field to the response from /sys/health/ endpoint #24270

Merged
merged 2 commits into from
Nov 28, 2023
Merged

[VAULT-22270] API: add enterprise field to the response from /sys/health/ endpoint #24270

merged 2 commits into from
Nov 28, 2023

Conversation

kubawi
Copy link
Contributor

@kubawi kubawi commented Nov 28, 2023

No description provided.

@kubawi kubawi added this to the 1.16.0-rc1 milestone Nov 28, 2023
@kubawi kubawi requested review from peteski22, marcboudreau and a team November 28, 2023 12:43
@kubawi kubawi self-assigned this Nov 28, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 28, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited

CI Results:
All Go tests succeeded! ✅

@kubawi kubawi force-pushed the kubawi/VAULT-22270/add-enterprise-field-to-sys-health-response branch from fab87d9 to ff0e57a Compare November 28, 2023 13:03
@kubawi kubawi marked this pull request as ready for review November 28, 2023 13:27
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

marcboudreau
marcboudreau approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@marcboudreau marcboudreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kubawi kubawi merged commit 8f064b9 into main Nov 28, 2023
161 checks passed
@kubawi kubawi deleted the kubawi/VAULT-22270/add-enterprise-field-to-sys-health-response branch November 28, 2023 14:22
peteski22
peteski22 reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@peteski22 peteski22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming in clutch @kubawi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteski22 peteski22 peteski22 left review comments

@marcboudreau marcboudreau marcboudreau approved these changes

Assignees

@kubawi kubawi

Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.16.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubawi @peteski22 @marcboudreau