Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize error response messages when invalid credentials are provided #23786

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Normalize error response messages when invalid credentials are provided #23786

merged 4 commits into from
Oct 23, 2023

Conversation

hghaf099
Copy link
Contributor

@hghaf099 hghaf099 commented Oct 23, 2023 •
edited

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 23, 2023
@hghaf099 hghaf099 requested a review from a team October 23, 2023 15:37
@hghaf099 hghaf099 added backport/1.13.x Backport changes to `release/1.13.x` backport/1.14.x Backport changes to `release/1.14.x` backport/1.15.x Backport changes to `release/1.15.x` labels Oct 23, 2023
@peteski22 peteski22 added this to the 1.13.10 milestone Oct 23, 2023
VioletHynes
VioletHynes reviewed Oct 23, 2023
View reviewed changes
changelog/23786.txt Outdated Show resolved Hide resolved
VioletHynes
VioletHynes approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tiny suggestion, but non-blocker :)

peteski22
peteski22 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@peteski22 peteski22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hghaf099 @VioletHynes
Update changelog/23786.txt
38c1500 
Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
@hghaf099 hghaf099 enabled auto-merge (squash) October 23, 2023 15:54
@hghaf099 hghaf099 merged commit 87376a1 into main Oct 23, 2023
104 of 105 checks passed
@hghaf099 hghaf099 deleted the normalize-approle-error branch October 23, 2023 15:59
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

This was referenced Oct 23, 2023
Merged
Merged
Merged
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@hghaf099 hghaf099 mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteski22 peteski22 peteski22 approved these changes

@VioletHynes VioletHynes VioletHynes approved these changes

Assignees
No one assigned
Labels
backport/1.13.x Backport changes to `release/1.13.x` backport/1.14.x Backport changes to `release/1.14.x` backport/1.15.x Backport changes to `release/1.15.x` hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone
Projects
None yet
Milestone
1.13.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hghaf099 @peteski22 @VioletHynes